Commit 421db1ab authored Mar 25, 2019 by Kishon Vijay Abraham I Committed by Lorenzo Pieralisi Apr 16, 2019

PCI: dwc: Fix dw_pcie_ep_find_capability() to return correct capability offset

commit beb4641a ("PCI: dwc: Add MSI-X callbacks handler") while
adding MSI-X callback handler, introduced dw_pcie_ep_find_capability()
and __dw_pcie_ep_find_next_cap() for finding the MSI and MSIX capability.

However if MSI or MSIX capability is the last capability (i.e there are
no additional items in the capabilities list and the Next Capability
Pointer is set to '0'), __dw_pcie_ep_find_next_cap will return '0'
even though MSI or MSIX capability may be present because of
incorrect ordering of the "next_cap_ptr" check. Fix it.

Fixes: beb4641a ("PCI: dwc: Add MSI-X callbacks handler")
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

parent 626961dd

drivers/pci/controller/dwc/pcie-designware-ep.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -46,16 +46,19 @@ static u8 __dw_pcie_ep_find_next_cap(struct dw_pcie *pci, u8 cap_ptr,
		u8 cap_id, next_cap_ptr;
		u16 reg;

		if (!cap_ptr)
		return 0;

		reg = dw_pcie_readw_dbi(pci, cap_ptr);
		next_cap_ptr = (reg & 0xff00) >> 8;
		cap_id = (reg & 0x00ff);

		if (!next_cap_ptr \|\| cap_id > PCI_CAP_ID_MAX)
		if (cap_id > PCI_CAP_ID_MAX)
		return 0;

		if (cap_id == cap)
		return cap_ptr;

		next_cap_ptr = (reg & 0xff00) >> 8;
		return __dw_pcie_ep_find_next_cap(pci, next_cap_ptr, cap);
		}

		@@ -67,9 +70,6 @@ static u8 dw_pcie_ep_find_capability(struct dw_pcie *pci, u8 cap)
		reg = dw_pcie_readw_dbi(pci, PCI_CAPABILITY_LIST);
		next_cap_ptr = (reg & 0x00ff);

		if (!next_cap_ptr)
		return 0;

		return __dw_pcie_ep_find_next_cap(pci, next_cap_ptr, cap);
		}

Admin message