bcache: deleted code comments for dead code in bch_data_insert_keys() (41fa4dee) · Commits · 戴 / test

In request.c:bch_data_insert_keys(), there is code comment for a piece of dead code. This patch deletes the dead code and its code comment since they are useless in practice. Signed-off-by:

Coly Li <colyli@suse.de> Signed-off-by:

Jens Axboe <axboe@kernel.dk>

drivers/md/bcache/request.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -62,18 +62,6 @@ static void bch_data_insert_keys(struct closure *cl)
		struct bkey *replace_key = op->replace ? &op->replace_key : NULL;
		int ret;

		/*
		* If we're looping, might already be waiting on
		* another journal write - can't wait on more than one journal write at
		* a time
		*
		* XXX: this looks wrong
		*/
		#if 0
		while (atomic_read(&s->cl.remaining) & CLOSURE_WAITING)
		closure_sync(&s->cl);
		#endif

		if (!op->replace)
		journal_ref = bch_journal(op->c, &op->insert_keys,
		op->flush_journal ? cl : NULL);

Admin message