Commit 41e7ed64 authored Oct 08, 2014 by Jan Kiszka Committed by Paolo Bonzini Oct 29, 2014

KVM: nVMX: Disable preemption while reading from shadow VMCS

In order to access the shadow VMCS, we need to load it. At this point,
vmx->loaded_vmcs->vmcs and the actually loaded one start to differ. If
we now get preempted by Linux, vmx_vcpu_put and, on return, the
vmx_vcpu_load will work against the wrong vmcs. That can cause
copy_shadow_to_vmcs12 to corrupt the vmcs12 state.

Fix the issue by disabling preemption during the copy operation.
copy_vmcs12_to_shadow is safe from this issue as it is executed by
vmx_vcpu_run when preemption is already disabled before vmentry.

This bug is exposed by running Jailhouse within KVM on CPUs with
shadow VMCS support. Jailhouse never expects an interrupt pending
vmexit, but the bug can cause it if, after copy_shadow_to_vmcs12
is preempted, the active VMCS happens to have the virtual interrupt
pending flag set in the CPU-based execution controls.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent cd9b8e2c

arch/x86/kvm/vmx.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -6426,6 +6426,8 @@ static void copy_shadow_to_vmcs12(struct vcpu_vmx *vmx)
		const unsigned long *fields = shadow_read_write_fields;
		const int num_fields = max_shadow_read_write_fields;

		preempt_disable();

		vmcs_load(shadow_vmcs);

		for (i = 0; i < num_fields; i++) {
		@@ -6449,6 +6451,8 @@ static void copy_shadow_to_vmcs12(struct vcpu_vmx *vmx)

		vmcs_clear(shadow_vmcs);
		vmcs_load(vmx->loaded_vmcs->vmcs);

		preempt_enable();
		}

		static void copy_vmcs12_to_shadow(struct vcpu_vmx *vmx)

Admin message