Commit 41e4e2cd authored Jan 03, 2019 by Yi-Hung Wei Committed by David S. Miller Jan 04, 2019

openvswitch: Fix IPv6 later frags parsing



The previous commit fa642f08
("openvswitch: Derive IP protocol number for IPv6 later frags")
introduces IP protocol number parsing for IPv6 later frags that can mess
up the network header length calculation logic, i.e. nh_len < 0.
However, the network header length calculation is mainly for deriving
the transport layer header in the key extraction process which the later
fragment does not apply.

Therefore, this commit skips the network header length calculation to
fix the issue.

Reported-by: Chris Mi <chrism@mellanox.com>
Reported-by: Greg Rose <gvrose8192@gmail.com>
Fixes: fa642f08 ("openvswitch: Derive IP protocol number for IPv6 later frags")
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ba3e1847

net/openvswitch/flow.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -276,9 +276,11 @@ static int parse_ipv6hdr(struct sk_buff skb, struct sw_flow_key key)

		nexthdr = ipv6_find_hdr(skb, &payload_ofs, -1, &frag_off, &flags);
		if (flags & IP6_FH_F_FRAG) {
		if (frag_off)
		if (frag_off) {
		key->ip.frag = OVS_FRAG_TYPE_LATER;
		else
		key->ip.proto = nexthdr;
		return 0;
		}
		key->ip.frag = OVS_FRAG_TYPE_FIRST;
		} else {
		key->ip.frag = OVS_FRAG_TYPE_NONE;

Admin message