Commit 41d6af11 authored Feb 28, 2008 by Amit Shah Committed by Avi Kivity Mar 24, 2009

KVM: is_long_mode() should check for EFER.LMA



is_long_mode currently checks the LongModeEnable bit in
EFER instead of the LongModeActive bit. This is wrong, but
we survived this till now since it wasn't triggered. This
breaks guests that go from long mode to compatibility mode.

This is noticed on a solaris guest and fixes bug #1842160

Signed-off-by: Amit Shah <amit.shah@qumranet.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>

parent 401d10de

arch/x86/kvm/mmu.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -54,7 +54,7 @@ static inline int kvm_mmu_reload(struct kvm_vcpu *vcpu)
		static inline int is_long_mode(struct kvm_vcpu *vcpu)
		{
		#ifdef CONFIG_X86_64
		return vcpu->arch.shadow_efer & EFER_LME;
		return vcpu->arch.shadow_efer & EFER_LMA;
		#else
		return 0;
		#endif

Admin message