Commit 41c90c18 authored by Marcel Holtmann's avatar Marcel Holtmann Committed by Johan Hedberg
Browse files

Bluetooth: Use privacy mode for non-connectable advertising 



When enabling non-connectable advertising, there is no need to advertise
with a public address or static address. In case LE privacy has not been
enabled a unresolvable private address will be used.

Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
parent 94b1fc92

net/bluetooth/mgmt.c

+4 −2
Original line number Diff line number Diff line
@@ -841,12 +841,14 @@ static void enable_advertising(struct hci_request *req) 
	struct hci_dev *hdev = req->hdev;

	struct hci_cp_le_set_adv_param cp;

	u8 own_addr_type, enable = 0x01;

	bool require_privacy;



	memset(&cp, 0, sizeof(cp));

	require_privacy = !test_bit(HCI_CONNECTABLE, &hdev->dev_flags);



	if (hci_update_random_address(req, false, &own_addr_type) < 0)

	if (hci_update_random_address(req, require_privacy, &own_addr_type) < 0)

		return;



	memset(&cp, 0, sizeof(cp));

	cp.min_interval = __constant_cpu_to_le16(0x0800);

	cp.max_interval = __constant_cpu_to_le16(0x0800);

	cp.type = get_adv_type(hdev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE