Commit 41c14527 authored by Dave Chinner's avatar Dave Chinner Committed by Dave Chinner
Browse files

xfs: XFS_IOCTL_SETXATTR can run in user namespaces 



Currently XFS_IOCTL_SETXATTR will fail if run in a user namespace as
it it not allowed to change project IDs. The current code, however,
also prevents any other change being made as well, so things like
extent size hints cannot be set in user namespaces. This is wrong,
so only disallow access to project IDs and related flags from inside
the init namespace.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent fd179b9c

fs/xfs/xfs_ioctl.c

+13 −9
Original line number Diff line number Diff line
@@ -1119,6 +1119,19 @@ xfs_ioctl_setattr( 
	    !xfs_sb_version_hasprojid32bit(&ip->i_mount->m_sb))

		return -EINVAL;



	/*

	 * Project Quota ID state is only allowed to change from within the init

	 * namespace. Enforce that restriction only if we are trying to change

	 * the quota ID state. Everything else is allowed in user namespaces.

	 */

	if (current_user_ns() != &init_user_ns) {

		if (xfs_get_projid(ip) != fa->fsx_projid)

			return -EINVAL;

		if ((fa->fsx_xflags & XFS_XFLAG_PROJINHERIT) !=

		    (ip->i_d.di_flags & XFS_DIFLAG_PROJINHERIT))

			return -EINVAL;

	}



	/*

	 * If disk quotas is on, we make sure that the dquots do exist on disk,

	 * before we start any other transactions. Trying to do this later
@@ -1141,15 +1154,6 @@ xfs_ioctl_setattr( 
		goto error_free_dquots;

	}



	/*

	 * Do a quota reservation only if projid is actually going to change.

	 * Only allow changing of projid from init_user_ns since it is a

	 * non user namespace aware identifier.

	 */

	if (current_user_ns() != &init_user_ns) {

		code = -EINVAL;

		goto error_return;

	}



	if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_PQUOTA_ON(mp) &&

	    xfs_get_projid(ip) != fa->fsx_projid) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE