Commit 41a46913 authored Apr 27, 2020 by Jesper Dangaard Brouer Committed by David S. Miller May 01, 2020

net: fix skb_panic to output real address

In skb_panic() the real pointer values are really needed to diagnose
issues, e.g. data and head are related (to calculate headroom). The
hashed versions of the addresses doesn't make much sense here. The
patch use the printk specifier %px to print the actual address.

The printk documentation on %px:
https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#unmodified-addresses

Fixes: ad67b74d ("printk: hash addresses printed with %p")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1bb694e2

net/core/skbuff.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -102,7 +102,7 @@ EXPORT_SYMBOL(sysctl_max_skb_frags);
		static void skb_panic(struct sk_buff skb, unsigned int sz, void addr,
		const char msg[])
		{
		pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n",
		pr_emerg("%s: text:%px len:%d put:%d head:%px data:%px tail:%#lx end:%#lx dev:%s\n",
		msg, addr, skb->len, sz, skb->head, skb->data,
		(unsigned long)skb->tail, (unsigned long)skb->end,
		skb->dev ? skb->dev->name : "<NULL>");