Commit 419684b2 authored May 14, 2019 by Nikolay Borisov Committed by David Sterba Jul 01, 2019

btrfs: dev-replace: Remove impossible WARN_ON



This WARN_ON can never trigger because src_device cannot be null.
btrfs_find_device_by_devspec always returns either an error or a valid
pointer to the device. Just remove it.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent b0d9e1ea

fs/btrfs/dev-replace.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -447,7 +447,6 @@ static int btrfs_dev_replace_start(struct btrfs_fs_info *fs_info,
		}

		dev_replace->cont_reading_from_srcdev_mode = read_src;
		WARN_ON(!src_device);
		dev_replace->srcdev = src_device;
		dev_replace->tgtdev = tgt_device;

Admin message