Commit 4188f063 authored Jun 25, 2018 by Dmitry Vyukov Committed by Ingo Molnar Jun 26, 2018

x86/mm: Get rid of KERN_CONT in show_fault_oops()



KERN_CONT leads to split lines in kernel output
and complicates useful changes to printk like
printing context before each line.

Only acceptable use of continuations is basically
boot-time testing.

Get rid of it.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20180625123808.227417-1-dvyukov@gmail.com


[ Removed unnecessary parentheses and prettified the printk statement. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 6f0d349d

arch/x86/mm/fault.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -671,13 +671,9 @@ show_fault_oops(struct pt_regs *regs, unsigned long error_code,
		printk(smep_warning, from_kuid(&init_user_ns, current_uid()));
		}

		printk(KERN_ALERT "BUG: unable to handle kernel ");
		if (address < PAGE_SIZE)
		printk(KERN_CONT "NULL pointer dereference");
		else
		printk(KERN_CONT "paging request");

		printk(KERN_CONT " at %px\n", (void *) address);
		pr_alert("BUG: unable to handle kernel %s at %px\n",
		address < PAGE_SIZE ? "NULL pointer dereference" : "paging request",
		(void *)address);

		dump_pagetable(address);
		}

Admin message