Commit 41766f87 authored by Alex Elder's avatar Alex Elder Committed by Sage Weil
Browse files

libceph: rename ceph_calc_object_layout() 



The purpose of ceph_calc_object_layout() is to fill in the pool
number and seed for a ceph_pg structure provided, based on a given
osd map and target object id.

Currently that function takes a file layout parameter, but the only
thing used out of that is its pool number.

Change the function so it takes a pool number rather than the full
file layout structure.  Only update the ceph_pg if the pool is found
in the osd map.  Get rid of few useless lines of code from the
function while there.

Since the function now very clearly just fills in the ceph_pg
structure it's provided, rename it ceph_calc_ceph_pg().

Signed-off-by: default avatarAlex Elder <elder@inktank.com>
Reviewed-by: default avatarJosh Durgin <josh.durgin@inktank.com>
parent ec02a2f2

fs/ceph/ioctl.c

+3 −2
Original line number Diff line number Diff line
@@ -208,8 +208,9 @@ static long ceph_ioctl_get_dataloc(struct file *file, void __user *arg) 


	snprintf(dl.object_name, sizeof(dl.object_name), "%llx.%08llx",

		 ceph_ino(inode), dl.object_no);

	ceph_calc_object_layout(&pgid, dl.object_name, &ci->i_layout,

				osdc->osdmap);



	ceph_calc_ceph_pg(&pgid, dl.object_name, osdc->osdmap,

		ceph_file_layout_pg_pool(ci->i_layout));



	dl.osd = ceph_calc_pg_primary(osdc->osdmap, pgid);

	if (dl.osd >= 0) {

include/linux/ceph/osdmap.h

+2 −4
Original line number Diff line number Diff line
@@ -131,10 +131,8 @@ extern int ceph_calc_file_object_mapping(struct ceph_file_layout *layout, 
					 u64 *bno, u64 *oxoff, u64 *oxlen);



/* calculate mapping of object to a placement group */

extern int ceph_calc_object_layout(struct ceph_pg *pg,

				   const char *oid,

				   struct ceph_file_layout *fl,

				   struct ceph_osdmap *osdmap);

extern int ceph_calc_ceph_pg(struct ceph_pg *pg, const char *oid,

			  struct ceph_osdmap *osdmap, uint64_t pool);

extern int ceph_calc_pg_acting(struct ceph_osdmap *osdmap,

			       struct ceph_pg pgid,

			       int *acting);

net/ceph/osd_client.c

+2 −2
Original line number Diff line number Diff line
@@ -948,8 +948,8 @@ static int __map_request(struct ceph_osd_client *osdc, 
	int err;



	dout("map_request %p tid %lld\n", req, req->r_tid);

	err = ceph_calc_object_layout(&pgid, req->r_oid,

				      &req->r_file_layout, osdc->osdmap);

	err = ceph_calc_ceph_pg(&pgid, req->r_oid, osdc->osdmap,

				ceph_file_layout_pg_pool(req->r_file_layout));

	if (err) {

		list_move(&req->r_req_lru_item, &osdc->req_notarget);

		return err;

net/ceph/osdmap.c

+9 −14
Original line number Diff line number Diff line
@@ -1111,27 +1111,22 @@ EXPORT_SYMBOL(ceph_calc_file_object_mapping); 
 * calculate an object layout (i.e. pgid) from an oid,

 * file_layout, and osdmap

 */

int ceph_calc_object_layout(struct ceph_pg *pg,

			    const char *oid,

			    struct ceph_file_layout *fl,

			    struct ceph_osdmap *osdmap)

int ceph_calc_ceph_pg(struct ceph_pg *pg, const char *oid,

			struct ceph_osdmap *osdmap, uint64_t pool)

{

	unsigned int num, num_mask;

	struct ceph_pg_pool_info *pool;

	struct ceph_pg_pool_info *pool_info;



	BUG_ON(!osdmap);

	pg->pool = le32_to_cpu(fl->fl_pg_pool);

	pool = __lookup_pg_pool(&osdmap->pg_pools, pg->pool);

	if (!pool)

	pool_info = __lookup_pg_pool(&osdmap->pg_pools, pool);

	if (!pool_info)

		return -EIO;

	pg->seed = ceph_str_hash(pool->object_hash, oid, strlen(oid));

	num = pool->pg_num;

	num_mask = pool->pg_num_mask;

	pg->pool = pool;

	pg->seed = ceph_str_hash(pool_info->object_hash, oid, strlen(oid));



	dout("calc_object_layout '%s' pgid %lld.%x\n", oid, pg->pool, pg->seed);

	dout("%s '%s' pgid %lld.%x\n", __func__, oid, pg->pool, pg->seed);

	return 0;

}

EXPORT_SYMBOL(ceph_calc_object_layout);

EXPORT_SYMBOL(ceph_calc_ceph_pg);



/*

 * Calculate raw osd vector for the given pgid.  Return pointer to osd

CRA Git | Maintained and supported by SUSTech CRA and CCSE