Commit 416c4613 authored Oct 11, 2018 by Christoph Hellwig Committed by Martin K. Petersen Oct 15, 2018

scsi: lpfc: remove a bogus pci_dma_sync_single_for_device call



dma_alloc_coherent allocates memory that can be used by the cpu and the
device at the same time, calls to pci_dma_sync_* are not required, and in
fact actively harmful on some architectures like arm.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 67d98f0a

drivers/scsi/lpfc/lpfc_bsg.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -2844,9 +2844,6 @@ diag_cmd_data_alloc(struct lpfc_hba *phba,

		if (nocopydata) {
		bpl->tus.f.bdeFlags = 0;
		pci_dma_sync_single_for_device(phba->pcidev,
		dmp->dma.phys, LPFC_BPL_SIZE, PCI_DMA_TODEVICE);

		} else {
		memset((uint8_t *)dmp->dma.virt, 0, cnt);
		bpl->tus.f.bdeFlags = BUFF_TYPE_BDE_64I;

Admin message