Commit 416bc512 authored Sep 29, 2006 by Roland McGrath Committed by Linus Torvalds Sep 29, 2006

[PATCH] Use decimal for PTRACE_ATTACH and PTRACE_DETACH.



It is sure confusing that linux/ptrace.h has:
	#define PTRACE_SINGLESTEP	   9
	#define PTRACE_ATTACH		0x10
	#define PTRACE_DETACH		0x11
	#define PTRACE_SYSCALL		  24
All the low-numbered constants are in decimal, but the last two in hex.
It sure makes it likely that someone will look at this and think that
9, 10, 11 are used, and that 16 and 17 are not used.

How about we use the same notation for all the numbers [0,24] in the
same short list?

Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent cf3e43db

include/linux/ptrace.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -16,8 +16,8 @@
		#define PTRACE_KILL 8
		#define PTRACE_SINGLESTEP 9

		#define PTRACE_ATTACH 0x10
		#define PTRACE_DETACH 0x11
		#define PTRACE_ATTACH 16
		#define PTRACE_DETACH 17

		#define PTRACE_SYSCALL 24

Admin message