Commit 41552199 authored May 09, 2019 by YueHaibing Committed by Martin K. Petersen May 20, 2019

scsi: myrs: Fix uninitialized variable



drivers/scsi/myrs.c: In function 'myrs_log_event':
drivers/scsi/myrs.c:821:24: warning: 'sshdr.sense_key' may be used uninitialized in this function [-Wmaybe-uninitialized]
  struct scsi_sense_hdr sshdr;

If ev->ev_code is not 0x1C, sshdr.sense_key may be used uninitialized. Fix
this by initializing variable 'sshdr' to 0.

Fixes: 77266186 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 69b9c52c

drivers/scsi/myrs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -818,7 +818,7 @@ static void myrs_log_event(struct myrs_hba cs, struct myrs_event ev)
		unsigned char ev_type, *ev_msg;
		struct Scsi_Host *shost = cs->host;
		struct scsi_device *sdev;
		struct scsi_sense_hdr sshdr;
		struct scsi_sense_hdr sshdr = {0};
		unsigned char sense_info[4];
		unsigned char cmd_specific[4];

Admin message