Commit 41387a59 authored Jul 20, 2016 by Sakari Ailus Committed by Mauro Carvalho Chehab Jan 27, 2017

[media] media: entity: Fix stream count check

There's a sanity check for the stream count remaining positive or zero on
error path, but instead of performing the check on the traversed entity it
is performed on the entity where traversal ends. Fix this.

Fixes: commit 3801bc7d ("[media] media: Media Controller fix to not let stream_count go negative")

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent bcb63314

drivers/media/media-entity.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -470,7 +470,7 @@ error:

		while ((entity_err = media_entity_graph_walk_next(graph))) {
		/* don't let the stream_count go negative */
		if (entity->stream_count > 0) {
		if (entity_err->stream_count > 0) {
		entity_err->stream_count--;
		if (entity_err->stream_count == 0)
		entity_err->pipe = NULL;