Commit 41309271 authored Apr 07, 2017 by Alexey Khoroshilov Committed by Mauro Carvalho Chehab Apr 10, 2017

[media] m2m-deinterlace: don't return zero on failure paths in deinterlace_probe()



If DMA does not support INTERLEAVE, deinterlace_probe() breaks off
initialization, releases dma channel, but returns zero.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 9d826ce8

drivers/media/platform/m2m-deinterlace.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1017,6 +1017,7 @@ static int deinterlace_probe(struct platform_device *pdev)

		if (!dma_has_cap(DMA_INTERLEAVE, pcdev->dma_chan->device->cap_mask)) {
		dev_err(&pdev->dev, "DMA does not support INTERLEAVE\n");
		ret = -ENODEV;
		goto rel_dma;
		}

Admin message