be2net: remove unused local rsstable array (4114ec90) · Commits · 戴 / test

Remove rsstable array and its initialization from be_set_rss_hash_opts(). The array became unused after " be2net: Support for configurable RSS hash key". The initial RSS table is now filled and stored for later usage during Rx queue creation. Signed-off-by:

Ivan Vecera <ivecera@redhat.com> Acked-by:

Sathya Perla <sathya.perla@avagotech.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/emulex/benet/be_ethtool.c

+2 −14

Original line number	Diff line number	Diff line
		@@ -1062,9 +1062,7 @@ static int be_get_rxnfc(struct net_device netdev, struct ethtool_rxnfc cmd,
		static int be_set_rss_hash_opts(struct be_adapter *adapter,
		struct ethtool_rxnfc *cmd)
		{
		struct be_rx_obj *rxo;
		int status = 0, i, j;
		u8 rsstable[128];
		int status;
		u32 rss_flags = adapter->rss_info.rss_flags;

		if (cmd->data != L3_RSS_FLAGS &&
		@@ -1113,17 +1111,7 @@ static int be_set_rss_hash_opts(struct be_adapter *adapter,
		}

		if (rss_flags == adapter->rss_info.rss_flags)
		return status;

		if (be_multi_rxq(adapter)) {
		for (j = 0; j < 128; j += adapter->num_rss_qs) {
		for_all_rss_queues(adapter, rxo, i) {
		if ((j + i) >= 128)
		break;
		rsstable[j + i] = rxo->rss_id;
		}
		}
		}
		return 0;

		status = be_cmd_rss_config(adapter, adapter->rss_info.rsstable,
		rss_flags, 128, adapter->rss_info.rss_hkey);

Admin message