Commit 410f25de authored Sep 05, 2019 by Colin Ian King Committed by Dmitry Torokhov Sep 05, 2019

Input: sidewinder - make array seq static const, makes object smaller



Don't populate the array seq on the stack but instead make it
static const. Makes the object code smaller by 30 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  22284	   3184	      0	  25468	   637c	drivers/input/joystick/sidewinder.o

After:
   text	   data	    bss	    dec	    hex	filename
  22158	   3280	      0	  25438	   635e	drivers/input/joystick/sidewinder.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 4370b231

drivers/input/joystick/sidewinder.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -223,7 +223,7 @@ static __u64 sw_get_bits(unsigned char *buf, int pos, int num, char bits)

		static void sw_init_digital(struct gameport *gameport)
		{
		int seq[] = { 140, 140+725, 140+300, 0 };
		static const int seq[] = { 140, 140+725, 140+300, 0 };
		unsigned long flags;
		int i, t;

Admin message