[PATCH] ieee1394: nodemgr: do not spawn kernel_thread for sysfs rescan (40fd89cc) · Commits · 戴 / test

nodemgr.c::fw_set_rescan() is used to re-run the driver core over nodemgr's representation of unit directories in order to initiate protocol driver probes. It is initiated via write access to one of nodemgr's sysfs attributes. The purpose is to attach drivers to units after switching a unit's ignore_driver attribute from 1 to 0. It is not really necessary to fork a kernel_thread for this job. The call to kernel_thread() can be eliminated to avoid the deprecated API and to simplify the code a bit. Signed-off-by:

Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by:

Ben Collins <bcollins@ubuntu.com>

drivers/ieee1394/nodemgr.c

+2 −17

Original line number	Diff line number	Diff line
		@@ -405,26 +405,11 @@ static ssize_t fw_get_destroy_node(struct bus_type bus, char buf)
		}
		static BUS_ATTR(destroy_node, S_IWUSR \| S_IRUGO, fw_get_destroy_node, fw_set_destroy_node);

		static int nodemgr_rescan_bus_thread(void *__unused)
		{
		/* No userlevel access needed */
		daemonize("kfwrescan");

		bus_rescan_devices(&ieee1394_bus_type);

		return 0;
		}

		static ssize_t fw_set_rescan(struct bus_type bus, const char buf, size_t count)
		{
		int state = simple_strtoul(buf, NULL, 10);

		/* Don't wait for this, or care about errors. Root could do
		* something stupid and spawn this a lot of times, but that's
		* root's fault. */
		if (state == 1)
		kernel_thread(nodemgr_rescan_bus_thread, NULL, CLONE_KERNEL);

		if (simple_strtoul(buf, NULL, 10) == 1)
		bus_rescan_devices(&ieee1394_bus_type);
		return count;
		}
		static ssize_t fw_get_rescan(struct bus_type bus, char buf)

Admin message