Commit 40efb09a authored Sep 24, 2019 by Navid Emamdoost Committed by Thomas Hellstrom Jan 15, 2020

drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add



In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory
for cres should be released.

Fixes: 18e4a466 ("drm/vmwgfx: Fix compat shader namespace")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>

parent 0d4c19f9

drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man,

		cres->hash.key = user_key \| (res_type << 24);
		ret = drm_ht_insert_item(&man->resources, &cres->hash);
		if (unlikely(ret != 0))
		if (unlikely(ret != 0)) {
		kfree(cres);
		goto out_invalid_key;
		}

		cres->state = VMW_CMDBUF_RES_ADD;
		cres->res = vmw_resource_reference(res);

Admin message