[IB] Have cq_resize() method take an int, not int* (40de2e54) · Commits · 戴 / test

Change the struct ib_device.resize_cq() method to take a plain integer that holds the new CQ size, rather than a pointer to an integer that it uses to return the new size. This makes the interface match the exported ib_resize_cq() signature, and allows the low-level driver to update the CQ size with proper locking if necessary. No in-tree drivers are exporting this method yet. Signed-off-by:

Roland Dreier <rolandd@cisco.com>

drivers/infiniband/core/verbs.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -324,16 +324,8 @@ EXPORT_SYMBOL(ib_destroy_cq);
		int ib_resize_cq(struct ib_cq *cq,
		int cqe)
		{
		int ret;

		if (!cq->device->resize_cq)
		return -ENOSYS;

		ret = cq->device->resize_cq(cq, &cqe);
		if (!ret)
		cq->cqe = cqe;

		return ret;
		return cq->device->resize_cq ?
		cq->device->resize_cq(cq, cqe) : -ENOSYS;
		}
		EXPORT_SYMBOL(ib_resize_cq);

include/rdma/ib_verbs.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -881,7 +881,7 @@ struct ib_device {
		struct ib_ucontext *context,
		struct ib_udata *udata);
		int (destroy_cq)(struct ib_cq cq);
		int (resize_cq)(struct ib_cq cq, int *cqe);
		int (resize_cq)(struct ib_cq cq, int cqe);
		int (poll_cq)(struct ib_cq cq, int num_entries,
		struct ib_wc *wc);
		int (peek_cq)(struct ib_cq cq, int wc_cnt);

Admin message