Commit 40d79624 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Tony Luck
Browse files

EDAC: Make edac_debugfs_create_x*() return void 



The return values of edac_debugfs_create_x16() and
edac_debugfs_create_x8() are never checked (as they don't need to be),
so no need to have them return anything, just make the functions return
void instead.

This is done with the goal of being able to change the debugfs_create_x*
functions to also not return a value.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: James Morse <james.morse@arm.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Link: https://lkml.kernel.org/r/20190611175433.GA5108@kroah.com
parent ff70cacc

drivers/edac/debugfs.c

+6 −6
Original line number Diff line number Diff line
@@ -118,23 +118,23 @@ edac_debugfs_create_file(const char *name, umode_t mode, struct dentry *parent, 
EXPORT_SYMBOL_GPL(edac_debugfs_create_file);



/* Wrapper for debugfs_create_x8() */

struct dentry *edac_debugfs_create_x8(const char *name, umode_t mode,

void edac_debugfs_create_x8(const char *name, umode_t mode,

			    struct dentry *parent, u8 *value)

{

	if (!parent)

		parent = edac_debugfs;



	return debugfs_create_x8(name, mode, parent, value);

	debugfs_create_x8(name, mode, parent, value);

}

EXPORT_SYMBOL_GPL(edac_debugfs_create_x8);



/* Wrapper for debugfs_create_x16() */

struct dentry *edac_debugfs_create_x16(const char *name, umode_t mode,

void edac_debugfs_create_x16(const char *name, umode_t mode,

			     struct dentry *parent, u16 *value)

{

	if (!parent)

		parent = edac_debugfs;



	return debugfs_create_x16(name, mode, parent, value);

	debugfs_create_x16(name, mode, parent, value);

}

EXPORT_SYMBOL_GPL(edac_debugfs_create_x16);

drivers/edac/edac_module.h

+8 −10
Original line number Diff line number Diff line
@@ -78,10 +78,10 @@ edac_debugfs_create_dir_at(const char *dirname, struct dentry *parent); 
struct dentry *

edac_debugfs_create_file(const char *name, umode_t mode, struct dentry *parent,

			 void *data, const struct file_operations *fops);

struct dentry *

edac_debugfs_create_x8(const char *name, umode_t mode, struct dentry *parent, u8 *value);

struct dentry *

edac_debugfs_create_x16(const char *name, umode_t mode, struct dentry *parent, u16 *value);

void edac_debugfs_create_x8(const char *name, umode_t mode,

			    struct dentry *parent, u8 *value);

void edac_debugfs_create_x16(const char *name, umode_t mode,

			     struct dentry *parent, u16 *value);

#else

static inline void edac_debugfs_init(void)					{ }

static inline void edac_debugfs_exit(void)					{ }
@@ -92,12 +92,10 @@ edac_debugfs_create_dir_at(const char *dirname, struct dentry *parent) { return 
static inline struct dentry *

edac_debugfs_create_file(const char *name, umode_t mode, struct dentry *parent,

			 void *data, const struct file_operations *fops)	{ return NULL; }

static inline struct dentry *

edac_debugfs_create_x8(const char *name, umode_t mode,

		       struct dentry *parent, u8 *value)			{ return NULL; }

static inline struct dentry *

edac_debugfs_create_x16(const char *name, umode_t mode,

		       struct dentry *parent, u16 *value)			{ return NULL; }

static inline void edac_debugfs_create_x8(const char *name, umode_t mode,

					  struct dentry *parent, u8 *value)	{ }

static inline void edac_debugfs_create_x16(const char *name, umode_t mode,

					   struct dentry *parent, u16 *value)	{ }

#endif



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE