Commit 40c8c85a authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Sam Ravnborg
Browse files

bootchart: improve output based on Dave Jones' feedback 



Dave Jones, in his blog, had some feedback about the bootchart script:
Primarily his complaint was that shorter delays weren't visualized.

The reason for that was that too small delays will have their labels
mixed up in the graph in an unreadable mess.

This patch has a fix for this; for one, it makes the output wider,
so more will fit.
The second part is that smaller delays are now shown with a
much smaller font for the label; while this isn't per se
readable at a 1:1 zoom, at least you can zoom in with most SVG
viewing applications and see what it is you are looking at.

Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
parent 8b249b68

scripts/bootgraph.pl

+11 −5
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ END 
}



print "<?xml version=\"1.0\" standalone=\"no\"?> \n";

print "<svg width=\"1000\" height=\"100%\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\">\n";

print "<svg width=\"2000\" height=\"100%\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\">\n";



my @styles;
@@ -105,8 +105,9 @@ $styles[9] = "fill:rgb(255,255,128);fill-opacity:0.5;stroke-width:1;stroke:rgb(0 
$styles[10] = "fill:rgb(255,128,255);fill-opacity:0.5;stroke-width:1;stroke:rgb(0,0,0)";

$styles[11] = "fill:rgb(128,255,255);fill-opacity:0.5;stroke-width:1;stroke:rgb(0,0,0)";



my $mult = 950.0 / ($maxtime - $firsttime);

my $threshold = ($maxtime - $firsttime) / 60.0;

my $mult = 1950.0 / ($maxtime - $firsttime);

my $threshold2 = ($maxtime - $firsttime) / 120.0;

my $threshold = $threshold2/10;

my $stylecounter = 0;

my %rows;

my $rowscount = 1;
@@ -116,7 +117,7 @@ foreach my $key (@initcalls) { 
	my $duration = $end{$key} - $start{$key};



	if ($duration >= $threshold) {

		my ($s, $s2, $e, $w, $y, $y2, $style);

		my ($s, $s2, $s3, $e, $w, $y, $y2, $style);

		my $pid = $pids{$key};



		if (!defined($rows{$pid})) {
@@ -125,6 +126,7 @@ foreach my $key (@initcalls) { 
		}

		$s = ($start{$key} - $firsttime) * $mult;

		$s2 = $s + 6;

		$s3 = $s + 1;

		$e = ($end{$key} - $firsttime) * $mult;

		$w = $e - $s;
@@ -138,7 +140,11 @@ foreach my $key (@initcalls) { 
		};



		print "<rect x=\"$s\" width=\"$w\" y=\"$y\" height=\"145\" style=\"$style\"/>\n";

		if ($duration >= $threshold2) {

			print "<text transform=\"translate($s2,$y2) rotate(90)\">$key</text>\n";

		} else {

			print "<text transform=\"translate($s3,$y2) rotate(90)\" font-size=\"3pt\">$key</text>\n";

		}

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE