usb: dwc3: gadget: fix XferNotReady debug print (40aa41fb) · Commits · 戴 / test

Only bit 3 of the event status bitfield is valid and the others should not be considered. Make sure SW matches documentation on that case to avoid bogus debugging prints which would confuse an engineer. Signed-off-by:

Felipe Balbi <balbi@ti.com>

drivers/usb/dwc3/core.h

+5 −0

Original line number	Diff line number	Diff line
		@@ -719,6 +719,11 @@ struct dwc3_event_depevt {
		u32 endpoint_event:4;
		u32 reserved11_10:2;
		u32 status:4;

		/* Within XferNotReady */
		#define DEPEVT_STATUS_TRANSFER_ACTIVE (1 << 3)

		/* Within XferComplete */
		#define DEPEVT_STATUS_BUSERR (1 << 0)
		#define DEPEVT_STATUS_SHORT (1 << 1)
		#define DEPEVT_STATUS_IOC (1 << 2)

drivers/usb/dwc3/gadget.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1657,7 +1657,8 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,
		int ret;

		dev_vdbg(dwc->dev, "%s: reason %s\n",
		dep->name, event->status
		dep->name, event->status &
		DEPEVT_STATUS_TRANSFER_ACTIVE
		? "Transfer Active"
		: "Transfer Not Active");

Admin message