Commit 408af87a authored Nov 04, 2010 by Jesper Juhl Committed by Linus Torvalds Nov 05, 2010

Clean up relay_alloc_page_array() slightly by using vzalloc rather than vmalloc and memset



We can optimize kernel/relay.c::relay_alloc_page_array() slightly by
using vzalloc.  The patch makes these changes:

 - use vzalloc instead of vmalloc+memset.
 - remove redundant local variable 'array'.
 - declare local 'pa_size' as const.

Cuts down nicely on both source and object-code size.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Pekka Enberg <penberg@kernel.org>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9a8a0cad

kernel/relay.c

+4 −11

Original line number	Diff line number	Diff line
		@@ -70,17 +70,10 @@ static const struct vm_operations_struct relay_file_mmap_ops = {
		*/
		static struct page **relay_alloc_page_array(unsigned int n_pages)
		{
		struct page **array;
		size_t pa_size = n_pages * sizeof(struct page *);

		if (pa_size > PAGE_SIZE) {
		array = vmalloc(pa_size);
		if (array)
		memset(array, 0, pa_size);
		} else {
		array = kzalloc(pa_size, GFP_KERNEL);
		}
		return array;
		const size_t pa_size = n_pages * sizeof(struct page *);
		if (pa_size > PAGE_SIZE)
		return vzalloc(pa_size);
		return kzalloc(pa_size, GFP_KERNEL);
		}

		/*

Admin message