Commit 408a60ed authored Nov 30, 2019 by Wei Yang Committed by Linus Torvalds Dec 01, 2019

mm/mmap.c: remove a never-triggered warning in __vma_adjust()

The upper level of "if" makes sure (end >= next->vm_end), which means
there are only two possibilities:

   1) end == next->vm_end
   2) end > next->vm_end

remove_next is assigned to be (1 + end > next->vm_end).  This means if
remove_next is 1, end must equal to next->vm_end.

The VM_WARN_ON will never trigger.

Link: http://lkml.kernel.org/r/20190912063126.13250-1-richardw.yang@linux.intel.com


Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e4dcad20

mm/mmap.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -769,8 +769,6 @@ int __vma_adjust(struct vm_area_struct *vma, unsigned long start,
		remove_next = 1 + (end > next->vm_end);
		VM_WARN_ON(remove_next == 2 &&
		end != next->vm_next->vm_end);
		VM_WARN_ON(remove_next == 1 &&
		end != next->vm_end);
		/* trim end to next, for case 6 first pass */
		end = next->vm_end;
		}

Admin message