Commit 4051f5eb authored Apr 19, 2018 by Dan Carpenter Committed by Bjorn Helgaas Apr 20, 2018

PCI: ibmphp: Fix use-before-set in get_max_bus_speed()



The "rc" variable is only initialized on the error path.  The caller
doesn't check the return but, if "rc" is non-zero, then this function is
basically a no-op.

Fixes: 3749c51a ("PCI: Make current and maximum bus speeds part of the PCI core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 60cc43fc

drivers/pci/hotplug/ibmphp_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -379,7 +379,7 @@ static int get_adapter_present(struct hotplug_slot hotplug_slot, u8 value)

		static int get_max_bus_speed(struct slot *slot)
		{
		int rc;
		int rc = 0;
		u8 mode = 0;
		enum pci_bus_speed speed;
		struct pci_bus *bus = slot->hotplug_slot->pci_slot->bus;

Admin message