Commit 4030b4c5 authored Sep 02, 2019 by Tianyu Lan Committed by Ingo Molnar Sep 02, 2019

x86/hyper-v: Fix overflow bug in fill_gva_list()



When the 'start' parameter is >=  0xFF000000 on 32-bit
systems, or >= 0xFFFFFFFF'FF000000 on 64-bit systems,
fill_gva_list() gets into an infinite loop.

With such inputs, 'cur' overflows after adding HV_TLB_FLUSH_UNIT
and always compares as less than end.  Memory is filled with
guest virtual addresses until the system crashes.

Fix this by never incrementing 'cur' to be larger than 'end'.

Reported-by: Jong Hyun Park <park.jonghyun@yonsei.ac.kr>
Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 2ffd9e33 ("x86/hyper-v: Use hypercall for remote TLB flush")
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 9b8bd476

arch/x86/hyperv/mmu.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -37,12 +37,14 @@ static inline int fill_gva_list(u64 gva_list[], int offset,
		* Lower 12 bits encode the number of additional
		* pages to flush (in addition to the 'cur' page).
		*/
		if (diff >= HV_TLB_FLUSH_UNIT)
		if (diff >= HV_TLB_FLUSH_UNIT) {
		gva_list[gva_n] \|= ~PAGE_MASK;
		else if (diff)
		cur += HV_TLB_FLUSH_UNIT;
		} else if (diff) {
		gva_list[gva_n] \|= (diff - 1) >> PAGE_SHIFT;
		cur = end;
		}

		cur += HV_TLB_FLUSH_UNIT;
		gva_n++;

		} while (cur < end);

Admin message