Commit 402482a6 authored Feb 25, 2020 by Nicolas Saenz Julienne Committed by David S. Miller Feb 26, 2020

net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed



Outdated Raspberry Pi 4 firmware might configure the external PHY as
rgmii although the kernel currently sets it as rgmii-rxid. This makes
connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
explicitly clear that bit whenever we don't need it.

Fixes: da388022 ("net: bcmgenet: Add RGMII_RXID support")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1521a67e

drivers/net/ethernet/broadcom/genet/bcmmii.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -294,6 +294,7 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
		*/
		if (priv->ext_phy) {
		reg = bcmgenet_ext_readl(priv, EXT_RGMII_OOB_CTRL);
		reg &= ~ID_MODE_DIS;
		reg \|= id_mode_dis;
		if (GENET_IS_V1(priv) \|\| GENET_IS_V2(priv) \|\| GENET_IS_V3(priv))
		reg \|= RGMII_MODE_EN_V123;

Admin message