libata: fix for sata_mv >64KB DMA segments (4007b493) · Commits · 戴 / test

Fix bug in sata_mv for cases where the IOMMU layer has merged SG entries to larger than 64KB. They need to be split up before being sent to the driver. Just for simplicity's sake, split up at 64K boundary instead of 64K size, since that's what the common code does anyway. Signed-off-by:

Olof Johansson <olof@lixom.net> Signed-off-by:

Jeff Garzik <jeff@garzik.org>

drivers/ata/sata_mv.c

+19 −7

Original line number	Diff line number	Diff line
		@@ -1139,17 +1139,29 @@ static unsigned int mv_fill_sg(struct ata_queued_cmd *qc)
		dma_addr_t addr = sg_dma_address(sg);
		u32 sg_len = sg_dma_len(sg);

		while (sg_len) {
		u32 offset = addr & 0xffff;
		u32 len = sg_len;

		if ((offset + sg_len > 0x10000))
		len = 0x10000 - offset;

		mv_sg->addr = cpu_to_le32(addr & 0xffffffff);
		mv_sg->addr_hi = cpu_to_le32((addr >> 16) >> 16);
		mv_sg->flags_size = cpu_to_le32(sg_len & 0xffff);
		mv_sg->flags_size = cpu_to_le32(len);

		sg_len -= len;
		addr += len;

		if (ata_sg_is_last(sg, qc))
		if (!sg_len && ata_sg_is_last(sg, qc))
		mv_sg->flags_size \|= cpu_to_le32(EPRD_FLAG_END_OF_TBL);

		mv_sg++;
		n_sg++;
		}

		}

		return n_sg;
		}

Admin message