Commit 3ff25e3c authored Jul 12, 2013 by hayeswang Committed by David S. Miller Jul 12, 2013

usb/net/r8152: fix integer overflow in expression



config: make ARCH=avr32 allyesconfig
drivers/net/usb/r8152.c: In function 'rtl8152_start_xmit':
drivers/net/usb/r8152.c:956: warning: integer overflow in expression

   955	memset(tx_desc, 0, sizeof(*tx_desc));
 > 956	tx_desc->opts1 = cpu_to_le32((len & TX_LEN_MASK) | TX_FS | TX_LS);
   957	tp->tx_skb = skb;

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Spotted-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 40dadff2

drivers/net/usb/r8152.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -934,7 +934,8 @@ static netdev_tx_t rtl8152_start_xmit(struct sk_buff *skb,
		struct r8152 *tp = netdev_priv(netdev);
		struct net_device_stats *stats = rtl8152_get_stats(netdev);
		struct tx_desc *tx_desc;
		int len, res;
		unsigned int len;
		int res;

		netif_stop_queue(netdev);
		len = skb->len;

Admin message