xfs: simplify xfs_setsize_buftarg callchain; remove unused arg (3fefdeee) · Commits · 戴 / test

The "verbose" argument to xfs_setsize_buftarg_flags() has been unused since: ffe37436 xfs: stop using the page cache to back the buffer cache Remove it, and fold the function into xfs_setsize_buftarg() now that there's no need for different types of callers. Fix inconsistent comment spacing while we're at it. Signed-off-by:

Eric Sandeen <sandeen@redhat.com> Reviewed-by:

Brian Foster <bfoster@redhat.com> Signed-off-by:

Ben Myers <bpm@sgi.com>

fs/xfs/xfs_buf.c

+8 −18

Original line number	Diff line number	Diff line
		@@ -1602,12 +1602,11 @@ xfs_free_buftarg(
		kmem_free(btp);
		}

		STATIC int
		xfs_setsize_buftarg_flags(
		int
		xfs_setsize_buftarg(
		xfs_buftarg_t *btp,
		unsigned int blocksize,
		unsigned int sectorsize,
		int verbose)
		unsigned int sectorsize)
		{
		btp->bt_bsize = blocksize;
		btp->bt_sshift = ffs(sectorsize) - 1;
		@@ -1637,17 +1636,8 @@ xfs_setsize_buftarg_early(
		xfs_buftarg_t *btp,
		struct block_device *bdev)
		{
		return xfs_setsize_buftarg_flags(btp,
		PAGE_SIZE, bdev_logical_block_size(bdev), 0);
		}

		int
		xfs_setsize_buftarg(
		xfs_buftarg_t *btp,
		unsigned int blocksize,
		unsigned int sectorsize)
		{
		return xfs_setsize_buftarg_flags(btp, blocksize, sectorsize, 1);
		return xfs_setsize_buftarg(btp, PAGE_SIZE,
		bdev_logical_block_size(bdev));
		}

		xfs_buftarg_t *

Admin message