Commit 3fe68cc1 authored Oct 14, 2008 by Julia Lawall Committed by James Bottomley Oct 23, 2008

[SCSI] sun3x_esp: Convert && to ||

The pattern !E && !E->fld is nonsensical.  The patch below updates this
according to the assumption that && should be ||.  But perhaps another
solution was intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@disable and_comm@
expression E;
identifier fld;
@@

- !E && !E->fld
+ !E || !E->fld
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent d4c9b736

drivers/scsi/sun3x_esp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -213,7 +213,7 @@ static int __devinit esp_sun3x_probe(struct platform_device *dev)
		esp->ops = &sun3x_esp_ops;

		res = platform_get_resource(dev, IORESOURCE_MEM, 0);
		if (!res && !res->start)
		if (!res \|\| !res->start)
		goto fail_unlink;

		esp->regs = ioremap_nocache(res->start, 0x20);
		@@ -221,7 +221,7 @@ static int __devinit esp_sun3x_probe(struct platform_device *dev)
		goto fail_unmap_regs;

		res = platform_get_resource(dev, IORESOURCE_MEM, 1);
		if (!res && !res->start)
		if (!res \|\| !res->start)
		goto fail_unmap_regs;

		esp->dma_regs = ioremap_nocache(res->start, 0x10);

Admin message