Commit 3fd1bb9b authored Aug 25, 2005 by Jean Delvare Committed by Linus Torvalds Aug 26, 2005

[PATCH] hwmon: Off-by-one error in fscpos driver

Coverity uncovered an off-by-one error in the fscpos driver, in function
set_temp_reset(). Writing to the temp3_reset sysfs file will lead to an
array overrun, in turn causing an I2C write to a random register of the
FSC Poseidon chip. Additionally, writing to temp1_reset and temp2_reset
will not work as expected. The fix is straightforward.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 566ecb9b

drivers/hwmon/fscpos.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -167,7 +167,7 @@ static ssize_t set_temp_reset(struct i2c_client *client, struct fscpos_data
		"experience to the module author.\n");

		/* Supported value: 2 (clears the status) */
		fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr], 2);
		fscpos_write_value(client, FSCPOS_REG_TEMP_STATE[nr - 1], 2);
		return count;
		}

Admin message