Commit 3fbd8716 authored May 28, 2012 by Rafal Prylowski Committed by Bryan Wu Jun 12, 2012

leds: don't disable blinking when writing the same value to delay_on or delay_off



Function led_set_software_blink() assumes that blink timer is still running,
but commit 488bc35b introduced disabling
of blink timer before each call to led_set_software_blink().

Correct led_software_blink():
1) remove protection against reprogramming blink timer to the same values,
   because it only disables blinking now,
2) remove unnecessary call to led_stop_software_blink().

Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

parent cfaf0251

drivers/leds/led-core.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -44,13 +44,6 @@ static void led_set_software_blink(struct led_classdev *led_cdev,
		if (!led_cdev->blink_brightness)
		led_cdev->blink_brightness = led_cdev->max_brightness;

		if (led_get_trigger_data(led_cdev) &&
		delay_on == led_cdev->blink_delay_on &&
		delay_off == led_cdev->blink_delay_off)
		return;

		led_stop_software_blink(led_cdev);

		led_cdev->blink_delay_on = delay_on;
		led_cdev->blink_delay_off = delay_off;

Admin message