Commit 3fb1823c authored Jul 22, 2014 by Lai Jiangshan Committed by Tejun Heo Jul 22, 2014

workqueue: remove the misnamed out_unlock label in get_unbound_pool()



After the locking was moved up to the caller of the get_unbound_pool(),
out_unlock label doesn't need to do any unlock operation and the name
became bad, so we just remove this label, and the only usage-site
"goto out_unlock" is subsituted to "return pool".

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 29b1cb41

kernel/workqueue.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3463,7 +3463,7 @@ static struct worker_pool get_unbound_pool(const struct workqueue_attrs attrs)
		hash_for_each_possible(unbound_pool_hash, pool, hash_node, hash) {
		if (wqattrs_equal(pool->attrs, attrs)) {
		pool->refcnt++;
		goto out_unlock;
		return pool;
		}
		}

		@@ -3501,7 +3501,7 @@ static struct worker_pool get_unbound_pool(const struct workqueue_attrs attrs)

		/* install */
		hash_add(unbound_pool_hash, &pool->hash_node, hash);
		out_unlock:

		return pool;
		fail:
		if (pool)

Admin message