Commit 3f89fea3 authored Jun 16, 2016 by Thierry Escande Committed by Samuel Ortiz Jul 06, 2016

NFC: digital: Rework error handling in DEP_RES response



The Digital Protocol stack used to send a NACK frame whatever the error
type it receives in digital_in_recv_dep_res(). It actually should only
send a NACK frame on CRC or parity check errors or on any transmission
error if a NACK frame was previously sent. Existing drivers used to send
EIO error for this kind of issues so this patch limits sending of NACK
frames on EIO errors. All other errors will be reported to the upper
layers.

Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent b7769344

net/nfc/digital_dep.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -664,7 +664,7 @@ static void digital_in_recv_dep_res(struct nfc_digital_dev ddev, void arg,
		rc = PTR_ERR(resp);
		resp = NULL;

		if (((rc != -ETIMEDOUT) \|\| ddev->nack_count) &&
		if ((rc == -EIO \|\| (rc == -ETIMEDOUT && ddev->nack_count)) &&
		(ddev->nack_count++ < DIGITAL_NFC_DEP_N_RETRY_NACK)) {
		ddev->atn_count = 0;

Admin message