Commit 3f88a15a authored Apr 21, 2017 by Christoph Hellwig Committed by Darrick J. Wong Apr 25, 2017

xfs: don't use bool values in trace buffers

Using bool values produces sparse warnings of this form:

fs/xfs/./xfs_trace.h:2252:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2252:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2278:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2278:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
fs/xfs/./xfs_trace.h:2307:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)

Just use a char instead to fix those up.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 12e4a381

fs/xfs/xfs_trace.h

+5 −5

Original line number	Diff line number	Diff line
		@@ -2255,8 +2255,8 @@ DECLARE_EVENT_CLASS(xfs_defer_class,
		TP_STRUCT__entry(
		__field(dev_t, dev)
		__field(void *, dop)
		__field(bool, committed)
		__field(bool, low)
		__field(char, committed)
		__field(char, low)
		),
		TP_fast_assign(
		__entry->dev = mp ? mp->m_super->s_dev : 0;
		@@ -2281,8 +2281,8 @@ DECLARE_EVENT_CLASS(xfs_defer_error_class,
		TP_STRUCT__entry(
		__field(dev_t, dev)
		__field(void *, dop)
		__field(bool, committed)
		__field(bool, low)
		__field(char, committed)
		__field(char, low)
		__field(int, error)
		),
		TP_fast_assign(
		@@ -2311,7 +2311,7 @@ DECLARE_EVENT_CLASS(xfs_defer_pending_class,
		__field(dev_t, dev)
		__field(int, type)
		__field(void *, intent)
		__field(bool, committed)
		__field(char, committed)
		__field(int, nr)
		),
		TP_fast_assign(

Admin message