Commit 3f6f7a17 authored May 23, 2019 by Maxime Chevallier Committed by David S. Miller May 23, 2019

net: mvpp2: cls: Fix leaked ethtool_rx_flow_rule



The flow_rule is only used when configuring the classification tables,
and should be free'd once we're done using it. The current code only
frees it in the error path.

Fixes: 90b509b3 ("net: mvpp2: cls: Add Classification offload support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 903869bd

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1271,6 +1271,9 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port,
		if (ret)
		goto clean_eth_rule;

		ethtool_rx_flow_rule_destroy(ethtool_rule);
		efs->rule.flow = NULL;

		memcpy(&efs->rxnfc, info, sizeof(*info));
		port->rfs_rules[efs->rule.loc] = efs;
		port->n_rfs_rules++;

Admin message