sfc: Remove bogus comment about MTU change and RX buffer overrun (3f65ea5b) · Commits · 戴 / test

RX DMA is limited by the length specified in each descriptor and not by the MAC. Over-length frames may get into the RX FIFO regardless of the MAC settings, due to a hardware bug, but they will be truncated by the packet DMA engine and reported as such in the completion event. Signed-off-by:

Ben Hutchings <bhutchings@solarflare.com>

drivers/net/ethernet/sfc/efx.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1953,8 +1953,6 @@ static int efx_change_mtu(struct net_device *net_dev, int new_mtu)
	netif_dbg(efx, drv, efx->net_dev, "changing MTU to %d\n", new_mtu);		netif_dbg(efx, drv, efx->net_dev, "changing MTU to %d\n", new_mtu);

	mutex_lock(&efx->mac_lock);		mutex_lock(&efx->mac_lock);
	/* Reconfigure the MAC before enabling the dma queues so that
	* the RX buffers don't overflow */
	net_dev->mtu = new_mtu;		net_dev->mtu = new_mtu;
	efx->type->reconfigure_mac(efx);		efx->type->reconfigure_mac(efx);
	mutex_unlock(&efx->mac_lock);		mutex_unlock(&efx->mac_lock);

Admin message