Commit 3f553b30 authored Mar 06, 2018 by Leon Yu Committed by Jessica Yu Mar 08, 2018

module: propagate error in modules_open()



otherwise kernel can oops later in seq_release() due to dereferencing null
file->private_data which is only set if seq_open() succeeds.

BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
IP: seq_release+0xc/0x30
Call Trace:
 close_pdeo+0x37/0xd0
 proc_reg_release+0x5d/0x60
 __fput+0x9d/0x1d0
 ____fput+0x9/0x10
 task_work_run+0x75/0x90
 do_exit+0x252/0xa00
 do_group_exit+0x36/0xb0
 SyS_exit_group+0xf/0x10

Fixes: 516fb7f2 ("/proc/module: use the same logic as /proc/kallsyms for address exposure")
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable@vger.kernel.org # 4.15+
Signed-off-by: Leon Yu <chianglungyu@gmail.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>

parent 661e50bc

kernel/module.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -4228,7 +4228,7 @@ static int modules_open(struct inode inode, struct file file)
	m->private = kallsyms_show_value() ? NULL : (void *)8ul;		m->private = kallsyms_show_value() ? NULL : (void *)8ul;
	}		}

	return 0;		return err;
	}		}

	static const struct file_operations proc_modules_operations = {		static const struct file_operations proc_modules_operations = {

Admin message