Commit 3f4724ea authored by Frederic Weisbecker's avatar Frederic Weisbecker
Browse files

cputime: Allow dynamic switch between tick/virtual based cputime accounting 



Allow to dynamically switch between tick and virtual based
cputime accounting. This way we can provide a kind of "on-demand"
virtual based cputime accounting. In this mode, the kernel relies
on the context tracking subsystem to dynamically probe on kernel
boundaries.

This is in preparation for being able to stop the timer tick in
more places than just the idle state. Doing so will depend on
CONFIG_VIRT_CPU_ACCOUNTING_GEN which makes it possible to account
the cputime without the tick by hooking on kernel/user boundaries.

Depending whether the tick is stopped or not, we can switch between
tick and vtime based accounting anytime in order to minimize the
overhead associated to user hooks.

Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
parent abf917cd

include/linux/vtime.h

+8 −0
Original line number Diff line number Diff line
@@ -10,12 +10,20 @@ extern void vtime_account_system_irqsafe(struct task_struct *tsk); 
extern void vtime_account_idle(struct task_struct *tsk);

extern void vtime_account_user(struct task_struct *tsk);

extern void vtime_account(struct task_struct *tsk);



#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN

extern bool vtime_accounting_enabled(void);

#else

static inline bool vtime_accounting_enabled(void) { return true; }

#endif



#else /* !CONFIG_VIRT_CPU_ACCOUNTING */

static inline void vtime_task_switch(struct task_struct *prev) { }

static inline void vtime_account_system(struct task_struct *tsk) { }

static inline void vtime_account_system_irqsafe(struct task_struct *tsk) { }

static inline void vtime_account_user(struct task_struct *tsk) { }

static inline void vtime_account(struct task_struct *tsk) { }

static inline bool vtime_accounting_enabled(void) { return false; }

#endif



#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN

kernel/sched/cputime.c

+31 −10
Original line number Diff line number Diff line
@@ -317,8 +317,6 @@ out: 
	rcu_read_unlock();

}



#ifndef CONFIG_VIRT_CPU_ACCOUNTING



#ifdef CONFIG_IRQ_TIME_ACCOUNTING

/*

 * Account a tick to a process and cpustat
@@ -383,11 +381,12 @@ static void irqtime_account_idle_ticks(int ticks) 
		irqtime_account_process_tick(current, 0, rq);

}

#else /* CONFIG_IRQ_TIME_ACCOUNTING */

static void irqtime_account_idle_ticks(int ticks) {}

static void irqtime_account_process_tick(struct task_struct *p, int user_tick,

static inline void irqtime_account_idle_ticks(int ticks) {}

static inline void irqtime_account_process_tick(struct task_struct *p, int user_tick,

						struct rq *rq) {}

#endif /* CONFIG_IRQ_TIME_ACCOUNTING */



#ifndef CONFIG_VIRT_CPU_ACCOUNTING_NATIVE

/*

 * Account a single tick of cpu time.

 * @p: the process that the cpu time gets accounted to
@@ -398,6 +397,9 @@ void account_process_tick(struct task_struct *p, int user_tick) 
	cputime_t one_jiffy_scaled = cputime_to_scaled(cputime_one_jiffy);

	struct rq *rq = this_rq();



	if (vtime_accounting_enabled())

		return;



	if (sched_clock_irqtime) {

		irqtime_account_process_tick(p, user_tick, rq);

		return;
@@ -439,8 +441,7 @@ void account_idle_ticks(unsigned long ticks) 


	account_idle_time(jiffies_to_cputime(ticks));

}



#endif

#endif /* !CONFIG_VIRT_CPU_ACCOUNTING_NATIVE */



/*

 * Use precise platform statistics if available:
@@ -475,6 +476,9 @@ EXPORT_SYMBOL_GPL(vtime_account_system_irqsafe); 
#ifndef __ARCH_HAS_VTIME_TASK_SWITCH

void vtime_task_switch(struct task_struct *prev)

{

	if (!vtime_accounting_enabled())

		return;



	if (is_idle_task(prev))

		vtime_account_idle(prev);

	else
@@ -498,6 +502,9 @@ void vtime_task_switch(struct task_struct *prev) 
#ifndef __ARCH_HAS_VTIME_ACCOUNT

void vtime_account(struct task_struct *tsk)

{

	if (!vtime_accounting_enabled())

		return;



	if (!in_interrupt()) {

		/*

		 * If we interrupted user, context_tracking_in_user()
@@ -520,7 +527,7 @@ void vtime_account(struct task_struct *tsk) 
EXPORT_SYMBOL_GPL(vtime_account);

#endif /* __ARCH_HAS_VTIME_ACCOUNT */



#else

#else /* !CONFIG_VIRT_CPU_ACCOUNTING */



static cputime_t scale_utime(cputime_t utime, cputime_t rtime, cputime_t total)

{
@@ -599,7 +606,7 @@ void thread_group_cputime_adjusted(struct task_struct *p, cputime_t *ut, cputime 
	thread_group_cputime(p, &cputime);

	cputime_adjust(&cputime, &p->signal->prev_cputime, ut, st);

}

#endif

#endif /* !CONFIG_VIRT_CPU_ACCOUNTING */



#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN

static DEFINE_PER_CPU(unsigned long long, cputime_snap);
@@ -617,14 +624,23 @@ static cputime_t get_vtime_delta(void) 


void vtime_account_system(struct task_struct *tsk)

{

	cputime_t delta_cpu = get_vtime_delta();

	cputime_t delta_cpu;



	if (!vtime_accounting_enabled())

		return;



	delta_cpu = get_vtime_delta();

	account_system_time(tsk, irq_count(), delta_cpu, cputime_to_scaled(delta_cpu));

}



void vtime_account_user(struct task_struct *tsk)

{

	cputime_t delta_cpu = get_vtime_delta();

	cputime_t delta_cpu;



	if (!vtime_accounting_enabled())

		return;



	delta_cpu = get_vtime_delta();



	account_user_time(tsk, delta_cpu, cputime_to_scaled(delta_cpu));

}
@@ -635,4 +651,9 @@ void vtime_account_idle(struct task_struct *tsk) 


	account_idle_time(delta_cpu);

}



bool vtime_accounting_enabled(void)

{

	return context_tracking_active();

}

#endif /* CONFIG_VIRT_CPU_ACCOUNTING_GEN */

kernel/time/tick-sched.c

+4 −1
Original line number Diff line number Diff line
@@ -631,8 +631,11 @@ static void tick_nohz_restart_sched_tick(struct tick_sched *ts, ktime_t now) 


static void tick_nohz_account_idle_ticks(struct tick_sched *ts)

{

#ifndef CONFIG_VIRT_CPU_ACCOUNTING

#ifndef CONFIG_VIRT_CPU_ACCOUNTING_NATIVE

	unsigned long ticks;



	if (vtime_accounting_enabled())

		return;

	/*

	 * We stopped the tick in idle. Update process times would miss the

	 * time we slept as update_process_times does only a 1 tick

CRA Git | Maintained and supported by SUSTech CRA and CCSE