iwlegacy: cleanup end of il_send_add_sta() (3f0267f6) · Commits · 戴 / test

This code causes a static checker warning because we check for "if (ret == 0)" but we have already had verified that was true. Clean it up a little. Signed-off-by:

Dan Carpenter <dan.carpenter@oracle.com> Acked-by:

Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/intel/iwlegacy/common.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -1865,14 +1865,14 @@ il_send_add_sta(struct il_priv il, struct il_addsta_cmd sta, u8 flags)

		cmd.len = il->ops->build_addsta_hcmd(sta, data);
		ret = il_send_cmd(il, &cmd);

		if (ret \|\| (flags & CMD_ASYNC))
		if (ret)
		return ret;
		if (flags & CMD_ASYNC)
		return 0;

		if (ret == 0) {
		pkt = (struct il_rx_pkt *)cmd.reply_page;
		ret = il_process_add_sta_resp(il, sta, pkt, true);
		}

		il_free_pages(il, cmd.reply_page);

		return ret;

Admin message