Commit 3ee339eb authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: dsa: mv88e6xxx: Fix masking of egress port 



Add missing ~ to the usage of the mask.

Reported-by: default avatarKevin Benson <Kevin.Benson@zii.aero>
Reported-by: default avatarChris Healy <Chris.Healy@zii.aero>
Fixes: 5c74c54c ("net: dsa: mv88e6xxx: Split monitor port configuration")
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ac004e84

drivers/net/dsa/mv88e6xxx/global1.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -278,13 +278,13 @@ int mv88e6095_g1_set_egress_port(struct mv88e6xxx_chip *chip, 
	switch (direction) {

	switch (direction) {

	case MV88E6XXX_EGRESS_DIR_INGRESS:

	case MV88E6XXX_EGRESS_DIR_INGRESS:

		dest_port_chip = &chip->ingress_dest_port;

		dest_port_chip = &chip->ingress_dest_port;

		reg &= MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;

		reg &= ~MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;

		reg |= port <<

		reg |= port <<

		       __bf_shf(MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK);

		       __bf_shf(MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK);

		break;

		break;

	case MV88E6XXX_EGRESS_DIR_EGRESS:

	case MV88E6XXX_EGRESS_DIR_EGRESS:

		dest_port_chip = &chip->egress_dest_port;

		dest_port_chip = &chip->egress_dest_port;

		reg &= MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;

		reg &= ~MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;

		reg |= port <<

		reg |= port <<

		       __bf_shf(MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK);

		       __bf_shf(MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK);

		break;

		break;

CRA Git | Maintained and supported by SUSTech CRA and CCSE