Commit 3ee2a199 authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds
Browse files

proc: : uninline name_to_int() 

Save ~360 bytes.

	add/remove: 1/0 grow/shrink: 0/4 up/down: 104/-463 (-359)
	function                                     old     new   delta
	name_to_int                                    -     104    +104
	proc_pid_lookup                              217     126     -91
	proc_lookupfd_common                         212     121     -91
	proc_task_lookup                             289     194     -95
	__proc_create                                588     402    -186

Link: http://lkml.kernel.org/r/20170912194850.GA17730@avx2


Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c6434012

fs/proc/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ proc-y += loadavg.o 
proc-y	+= meminfo.o

proc-y	+= stat.o

proc-y	+= uptime.o

proc-y	+= util.o

proc-y	+= version.o

proc-y	+= softirqs.o

proc-y	+= namespaces.o

fs/proc/internal.h

+1 −22
Original line number Diff line number Diff line
@@ -103,28 +103,7 @@ static inline struct task_struct *get_proc_task(struct inode *inode) 
void task_dump_owner(struct task_struct *task, mode_t mode,

		     kuid_t *ruid, kgid_t *rgid);



static inline unsigned name_to_int(const struct qstr *qstr)

{

	const char *name = qstr->name;

	int len = qstr->len;

	unsigned n = 0;



	if (len > 1 && *name == '0')

		goto out;

	while (len-- > 0) {

		unsigned c = *name++ - '0';

		if (c > 9)

			goto out;

		if (n >= (~0U-9)/10)

			goto out;

		n *= 10;

		n += c;

	}

	return n;

out:

	return ~0U;

}



unsigned name_to_int(const struct qstr *qstr);

/*

 * Offset of the first process in the /proc root directory..

 */

fs/proc/util.c

0 → 100644
+23 −0
Original line number Diff line number Diff line 
#include <linux/dcache.h>



unsigned name_to_int(const struct qstr *qstr)

{

	const char *name = qstr->name;

	int len = qstr->len;

	unsigned n = 0;



	if (len > 1 && *name == '0')

		goto out;

	while (len-- > 0) {

		unsigned c = *name++ - '0';

		if (c > 9)

			goto out;

		if (n >= (~0U-9)/10)

			goto out;

		n *= 10;

		n += c;

	}

	return n;

out:

	return ~0U;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE