Commit 3ece60e3 authored Oct 20, 2020 by Colin Ian King Committed by Steve French Oct 20, 2020

cifs: make const array static, makes object smaller



Don't populate const array smb3_create_tag_posix on the stack but
instead make it static. Makes the object code smaller by 50 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
 150184	  47167	      0	 197351	  302e7	fs/cifs/smb2pdu.o

After:
    text	   data	    bss	    dec	    hex	filename
 150070	  47231	      0	 197301	  302b5	fs/cifs/smb2pdu.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 9934430e

fs/cifs/smb2pdu.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -1981,9 +1981,11 @@ smb2_parse_contexts(struct TCP_Server_Info *server,
		unsigned int next;
		unsigned int remaining;
		char *name;
		const char smb3_create_tag_posix[] = {0x93, 0xAD, 0x25, 0x50, 0x9C,
		static const char smb3_create_tag_posix[] = {
		0x93, 0xAD, 0x25, 0x50, 0x9C,
		0xB4, 0x11, 0xE7, 0xB4, 0x23, 0x83,
		0xDE, 0x96, 0x8B, 0xCD, 0x7C};
		0xDE, 0x96, 0x8B, 0xCD, 0x7C
		};

		*oplock = 0;
		data_offset = (char *)rsp + le32_to_cpu(rsp->CreateContextsOffset);

Admin message