Commit 3ecc8292 authored May 27, 2020 by Amit Kucheria Committed by Daniel Lezcano Jun 29, 2020

thermal/drivers/tsens: Fix compilation warnings by making functions static



After merging tsens-common.c into tsens.c, we can now mark some
functions static so they don't need any prototype declarations. This
fixes the following issue reported by lkp.

>> drivers/thermal/qcom/tsens.c:385:13: warning: no previous prototype for 'tsens_critical_irq_thread' [-Wmissing-prototypes]
385 | irqreturn_t tsens_critical_irq_thread(int irq, void *data)
|             ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:455:13: warning: no previous prototype for 'tsens_irq_thread' [-Wmissing-prototypes]
455 | irqreturn_t tsens_irq_thread(int irq, void *data)
|             ^~~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:523:5: warning: no previous prototype for 'tsens_set_trips' [-Wmissing-prototypes]
523 | int tsens_set_trips(void *_sensor, int low, int high)
|     ^~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:560:5: warning: no previous prototype for 'tsens_enable_irq' [-Wmissing-prototypes]
560 | int tsens_enable_irq(struct tsens_priv *priv)
|     ^~~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:573:6: warning: no previous prototype for 'tsens_disable_irq' [-Wmissing-prototypes]
573 | void tsens_disable_irq(struct tsens_priv *priv)
|      ^~~~~~~~~~~~~~~~~

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/6757a26876b29922929abf64b1c11fa3b3033d03.1590579709.git.amit.kucheria@linaro.org

parent b4147917

drivers/thermal/qcom/tsens.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -382,7 +382,7 @@ static inline u32 masked_irq(u32 hw_id, u32 mask, enum tsens_ver ver)
		*
		* Return: IRQ_HANDLED
		*/
		irqreturn_t tsens_critical_irq_thread(int irq, void *data)
		static irqreturn_t tsens_critical_irq_thread(int irq, void *data)
		{
		struct tsens_priv *priv = data;
		struct tsens_irq_data d;
		@@ -452,7 +452,7 @@ irqreturn_t tsens_critical_irq_thread(int irq, void *data)
		*
		* Return: IRQ_HANDLED
		*/
		irqreturn_t tsens_irq_thread(int irq, void *data)
		static irqreturn_t tsens_irq_thread(int irq, void *data)
		{
		struct tsens_priv *priv = data;
		struct tsens_irq_data d;
		@@ -520,7 +520,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
		return IRQ_HANDLED;
		}

		int tsens_set_trips(void *_sensor, int low, int high)
		static int tsens_set_trips(void *_sensor, int low, int high)
		{
		struct tsens_sensor *s = _sensor;
		struct tsens_priv *priv = s->priv;
		@@ -557,7 +557,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
		return 0;
		}

		int tsens_enable_irq(struct tsens_priv *priv)
		static int tsens_enable_irq(struct tsens_priv *priv)
		{
		int ret;
		int val = tsens_version(priv) > VER_1_X ? 7 : 1;
		@@ -570,7 +570,7 @@ int tsens_enable_irq(struct tsens_priv *priv)
		return ret;
		}

		void tsens_disable_irq(struct tsens_priv *priv)
		static void tsens_disable_irq(struct tsens_priv *priv)
		{
		regmap_field_write(priv->rf[INT_EN], 0);
		}

Admin message