hwmon: (i5500_temp) use permission-specific DEVICE_ATTR variants (3eb52cfd) · Commits · 戴 / test

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by:

Julia Lawall <Julia.Lawall@lip6.fr> [groeck: Updated description] Signed-off-by:

Guenter Roeck <linux@roeck-us.net>

drivers/hwmon/i5500_temp.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -43,7 +43,7 @@
		*/

		/* Sensor resolution : 0.5 degree C */
		static ssize_t show_temp(struct device *dev,
		static ssize_t temp1_input_show(struct device *dev,
		struct device_attribute devattr, char buf)
		{
		struct pci_dev *pdev = to_pci_dev(dev->parent);
		@@ -83,7 +83,7 @@ static ssize_t show_alarm(struct device *dev,
		return sprintf(buf, "%u\n", (unsigned int)ctsts & (1 << nr));
		}

		static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL);
		static DEVICE_ATTR_RO(temp1_input);
		static SENSOR_DEVICE_ATTR(temp1_crit, S_IRUGO, show_thresh, NULL, 0xE2);
		static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO, show_thresh, NULL, 0xEC);
		static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO, show_thresh, NULL, 0xEE);

Admin message