Commit 3ea8094c authored Mar 23, 2020 by Serge Semin Committed by Linus Walleij Apr 17, 2020

gpio: dwapb: Use optional-clocks interface for APB ref-clock



The common clocks kernel framework provides a generic way to use
an optional reference clock sources. If it's utilized there is no
need in checking whether the clock descriptor pointer is actually a
negative error at the moment of the prepare/unprepare clocks method
calling. So if the corresponding clock source is provided, then
getting an error shall actually terminate the device probe procedure.
If it isn't specified then the driver shall proceed with further
initializations.

We'll use the optional clocks getting method to handle the APB reference
clock, which can be provided for instance in the device of-node with
"bus" clock-name.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200323195401.30338-5-Sergey.Semin@baikalelectronics.ru


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c55812af

drivers/gpio/gpio-dwapb.c

+11 −9

Original line number	Diff line number	Diff line
		@@ -690,14 +690,17 @@ static int dwapb_gpio_probe(struct platform_device *pdev)
		return PTR_ERR(gpio->regs);

		/* Optional bus clock */
		gpio->clk = devm_clk_get(&pdev->dev, "bus");
		if (!IS_ERR(gpio->clk)) {
		gpio->clk = devm_clk_get_optional(&pdev->dev, "bus");
		if (IS_ERR(gpio->clk)) {
		dev_err(&pdev->dev, "Cannot get APB clock\n");
		return PTR_ERR(gpio->clk);
		}

		err = clk_prepare_enable(gpio->clk);
		if (err) {
		dev_info(&pdev->dev, "Cannot enable clock\n");
		dev_err(&pdev->dev, "Cannot enable APB clock\n");
		return err;
		}
		}

		gpio->flags = 0;
		if (dev->of_node) {
		@@ -793,7 +796,6 @@ static int dwapb_gpio_resume(struct device *dev)
		unsigned long flags;
		int i;

		if (!IS_ERR(gpio->clk))
		clk_prepare_enable(gpio->clk);

		spin_lock_irqsave(&gc->bgpio_lock, flags);

Admin message