Commit 3e9d08ec authored by Bruce Rogers's avatar Bruce Rogers Committed by David S. Miller
Browse files

virtio_net: Add schedule check to napi_enable call 



Under harsh testing conditions, including low memory, the guest would
stop receiving packets. With this patch applied we no longer see any
problems in the driver while performing these tests for extended periods
of time.

Make sure napi is scheduled subsequent to each napi_enable.

Signed-off-by: default avatarBruce Rogers <brogers@novell.com>
Signed-off-by: default avatarOlaf Kirch <okir@suse.de>
Cc: stable@kernel.org
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 96642d42

drivers/net/virtio_net.c

+16 −11
Original line number Diff line number Diff line
@@ -446,6 +446,20 @@ static void skb_recv_done(struct virtqueue *rvq) 
	}

}



static void virtnet_napi_enable(struct virtnet_info *vi)

{

	napi_enable(&vi->napi);



	/* If all buffers were filled by other side before we napi_enabled, we

	 * won't get another interrupt, so process any outstanding packets

	 * now.  virtnet_poll wants re-enable the queue, so we disable here.

	 * We synchronize against interrupts via NAPI_STATE_SCHED */

	if (napi_schedule_prep(&vi->napi)) {

		virtqueue_disable_cb(vi->rvq);

		__napi_schedule(&vi->napi);

	}

}



static void refill_work(struct work_struct *work)

{

	struct virtnet_info *vi;
@@ -454,7 +468,7 @@ static void refill_work(struct work_struct *work) 
	vi = container_of(work, struct virtnet_info, refill.work);

	napi_disable(&vi->napi);

	still_empty = !try_fill_recv(vi, GFP_KERNEL);

	napi_enable(&vi->napi);

	virtnet_napi_enable(vi);



	/* In theory, this can happen: if we don't get any buffers in

	 * we will *never* try to fill again. */
@@ -638,16 +652,7 @@ static int virtnet_open(struct net_device *dev) 
{

	struct virtnet_info *vi = netdev_priv(dev);



	napi_enable(&vi->napi);



	/* If all buffers were filled by other side before we napi_enabled, we

	 * won't get another interrupt, so process any outstanding packets

	 * now.  virtnet_poll wants re-enable the queue, so we disable here.

	 * We synchronize against interrupts via NAPI_STATE_SCHED */

	if (napi_schedule_prep(&vi->napi)) {

		virtqueue_disable_cb(vi->rvq);

		__napi_schedule(&vi->napi);

	}

	virtnet_napi_enable(vi);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE